Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1752#discussion_r159976892
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -528,8 +543,17 @@ public void decodeHeadersAndProperties(final ByteBuf
buffer) {
private void decodeHeadersAndProperties(final ByteBuf buffer, boolean
lazyProperties) {
messageIDPosition = buffer.readerIndex();
messageID = buffer.readLong();
-
- address = SimpleString.readNullableSimpleString(buffer);
+ int b = buffer.readByte();
--- End diff --
Shouldnt this logic remain in SimpleString, as you could read strings
(especially address in many places)
---
