[GitHub] activemq-artemis pull request #1752: ARTEMIS-1586 Reduce GC pressure due to ...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1752#discussion_r159993639
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
 ---
    @@ -329,7 +331,9 @@ public boolean containsProperty(final SimpleString key) 
{
           }
        }
     
    -   public synchronized void decode(final ByteBuf buffer) {
    --- End diff --
    
    its not, you removed a public method, from a very common class thats 
exposed to clients. 


---