Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1752#discussion_r160010613
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -528,8 +543,17 @@ public void decodeHeadersAndProperties(final ByteBuf
buffer) {
private void decodeHeadersAndProperties(final ByteBuf buffer, boolean
lazyProperties) {
messageIDPosition = buffer.readerIndex();
messageID = buffer.readLong();
-
- address = SimpleString.readNullableSimpleString(buffer);
+ int b = buffer.readByte();
+ if (b != DataConstants.NULL) {
+ final int length = buffer.readInt();
+ if (keysInterner != null) {
+ address = keysInterner.intern(buffer, length);
--- End diff --
This is a very good point..yes, agree!
---
