Github user stanlyDoge commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1750#discussion_r160086429
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
 ---
    @@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws 
Exception {
     
           server.stop();
        }
    +
    +   @Test
    +   public void testHandshakeTimeoutWithValueSet() throws Exception {
    +      JMSServerManager jmsServer;
    --- End diff --
    
    Good point with JMSServerManager, thanks. 
    The issue is about unability to set timeout value using conf file so using 
it is intentional. Setting this value programmatically is done 
[here](https://github.com/apache/activemq-artemis/pull/1534/files#diff-70ef2b6fc0b6f5e37ea6023acce65b8c).
 Or did you think anything else?


---

Reply via email to