Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1772 IMO, it's less clean because now there are 2 places which are returning 0 in case of an error. In any case, it's really not a big deal. One additional question here...Is this NPE mainly theoretical or is there a specific use-case which triggers it? If the former then I'm even less in favor of merging the PR. If the latter then it would be worth adding a test or maybe just describing the use-case in the commit message.
---