Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1771#discussion_r162122543
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
---
@@ -622,8 +622,8 @@ public static String getDefaultClusterPassword() {
/**
* This option controls whether passwords in server configuration need
be masked. If set to "true" the passwords are masked.
*/
- public static boolean isDefaultMaskPassword() {
- return DEFAULT_MASK_PASSWORD;
+ public static Boolean isDefaultMaskPassword() {
--- End diff --
Why this?
Why you need a third state? true / false / undefined?
Why not just keep it boolean.. either mask it or not...
Besides.. if you really need the third option.. I would make
DEFAULT_MASK_PASSWORD = null; instead of returning null here.
I couldn't understand why you need it.
---
