Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1781#discussion_r162473145
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java
 ---
    @@ -423,8 +423,8 @@ public static String getDefaultHapolicyBackupStrategy() 
{
        // Default database url.  Derby database is used by default.
        private static String DEFAULT_DATABASE_URL = null;
     
    -   // Default JDBC Driver class name
    -   private static String DEFAULT_JDBC_DRIVER_CLASS_NAME = null;
    +   // Default JDBC Driver class name, derby by default just for demo 
purposes
    +   private static String DEFAULT_JDBC_DRIVER_CLASS_NAME = 
"org.apache.derby.jdbc.EmbeddedDriver";
    --- End diff --
    
    Should this be null since we won't be packaging Derby?


---

Reply via email to