Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1800
  
    @franz1981 If the test fails, whether cleanly or not, we get reported and 
should fix it. The leakage is not important here. After you fix it and it begin 
to pass, the thread check rule will perform check on it, making sure it doesn't 
leak threads. Let's say there are 2 situations:
    
    1) first test passes but secretly leaking threads and caused second test 
fail.
    2) first test failed and also leaking thread and caused second test fail.
    
    IMO the case 1) would be much harder to debug. So in case 1) the first test 
should be checked to make sure it doesn't pollute others. In case 2) however, 
you know the first test failed and you can be sure it fails on its own, there 
for a real failure. So no matter how many more failures follow, you will have 
to fix the first failure first. Once it passes, the thread check rule kicks in 
to make sure the leak won't happen.



---

Reply via email to