Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1807#discussion_r163301265
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -532,7 +532,7 @@ public AddressInfo updateAddressInfo(SimpleString
addressName,
public AddressInfo removeAddressInfo(SimpleString address) throws
Exception {
synchronized (addressLock) {
server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin ->
plugin.beforeRemoveAddress(address) : null);
- Bindings bindingsForAddress = getBindingsForAddress(address);
+ final Bindings bindingsForAddress = getDirectBindings(address);
--- End diff --
Looking at this, it seems it completely will ignore wildcard config. Im not
so sure this is a good idea, as it takes into account these.
e.g. what happens if someone is using different wildcards? Also it be good
to add test cases where alternative wildcards are used to make sure
removeAddress still works.
---
