Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1834#discussion_r165305348 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java --- @@ -530,48 +539,34 @@ public synchronized void start() { if (System.getProperty(ACTIVEMQ_TRUSTSTORE_PASSWORD_PROP_NAME) != null) { realTrustStorePassword = System.getProperty(ACTIVEMQ_TRUSTSTORE_PASSWORD_PROP_NAME); } - context = SSLSupport.createContext(realKeyStoreProvider, realKeyStorePath, realKeyStorePassword, realTrustStoreProvider, realTrustStorePath, realTrustStorePassword, trustAll, crlPath); + } } catch (Exception e) { close(); IllegalStateException ise = new IllegalStateException("Unable to create NettyConnector for " + host + ":" + port); ise.initCause(e); throw ise; } - } else { - context = null; // Unused } - if (context != null && useServlet) { - // TODO: Fix me - //bootstrap.setOption("sslContext", context); - } + //if (context != null && useServlet) { + // TODO: Fix me + //bootstrap.setOption("sslContext", context); + //} bootstrap.handler(new ChannelInitializer<Channel>() { --- End diff -- this probably could be made a lamda.
---