Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1829#discussion_r165333289
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -571,6 +571,8 @@ public AddressInfo getAddressInfo(SimpleString
addressName) {
// even though failover is complete
@Override
public synchronized void addBinding(final Binding binding) throws
Exception {
+ server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin ->
plugin.beforeAddBinding(binding) : null);
--- End diff --
I can change it everywhere the plugins are called. There are some hot
paths where the plugins are called such as during message routing so if that
change will improve performance then that is fine.
---
