Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1849#discussion_r165898852
  
    --- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
    @@ -713,12 +730,16 @@ public void reconnect(AMQConnectionContext 
existingContext, ConnectionInfo info)
           context.incRefCount();
        }
     
    +   private static void traceSendCommand(Command command) {
    +      ActiveMQServerLogger.LOGGER.trace("sending " + command);
    +   }
    +
        /**
         * This will answer with commands to the client
         */
        public boolean sendCommand(final Command command) {
    -      if (ActiveMQServerLogger.LOGGER.isTraceEnabled()) {
    -         ActiveMQServerLogger.LOGGER.trace("sending " + command);
    +      if (ACTIVE_MQ_SERVER_LOGGER_TRACE_ENABLED) {
    --- End diff --
    
    Was this really needed? From a code consistency POV, this is an odd one 
out, either all should follow in the code or not.


---

Reply via email to