Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1853#discussion_r166630869
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/codec/PageCountPendingImpl.java
---
@@ -62,21 +67,41 @@ public long getPageID() {
return pageID;
}
+ /**
+ * @return the persistentSize
+ */
+ @Override
+ public long getPersistentSize() {
+ return persistentSize;
+ }
+
+ /**
+ * @param persistentSize the persistentSize to set
+ */
+ public void setPersistentSize(long persistentSize) {
+ this.persistentSize = persistentSize;
+ }
+
@Override
public int getEncodeSize() {
- return DataConstants.SIZE_LONG * 2;
+ return DataConstants.SIZE_LONG * 3;
}
@Override
public void encode(ActiveMQBuffer buffer) {
buffer.writeLong(queueID);
buffer.writeLong(pageID);
+ buffer.writeLong(persistentSize);
--- End diff --
OIC.. you already implemented it..
I would like to have a compatibility test validating that.. there's a
journal test on the new compatibility testsuite already... but not one with
paging.. and validating the counters...
If you have a way to do it.. it would be great.. otherwise let me know and
I will do it.
---
