[GitHub] activemq-artemis pull request #1899: ARTEMIS-1700 Fixed deadlock in paging s...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1899#discussion_r170695023
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/actors/ArtemisExecutor.java
 ---
    @@ -50,6 +50,16 @@ default int shutdownNow(Consumer<? super Runnable> 
onPendingTask) {
           return 0;
        }
     
    +   default boolean flush(long timeout, TimeUnit unit) {
    +      CountDownLatch latch = new CountDownLatch(1);
    +      execute(latch::countDown);
    --- End diff --
    
    This won’t be used at all.  It’s just the default implementation for 
tests.  OrderedExecutor has an implementation. 


---