Github user johnpoth commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1922#discussion_r171908429
--- Diff: tests/karaf-client-integration-tests/pom.xml ---
@@ -36,6 +36,18 @@
</properties>
<dependencies>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>activemq-client</artifactId>
+ <scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <!--Let's compile against JMS 2-->
--- End diff --
Hi @jbertram thanks for reviewing!
I'm excluding the JMS 1.1 artifact, so we are compiling against JMS 2
(which is brought on the classpath transitively by artemis-jms-client). It was
causing compiling issues because javax.jms.Connection doesn't implement
AutoCloseable in JMS 1.1 whereas it does in JMS 2 which makes it possible to
use in try-with-resources statements.
Thanks!
---
