Github user nlippke commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1822#discussion_r172812406
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -109,7 +109,7 @@ public void stop() throws SQLException {
protected abstract void createSchema() throws SQLException;
protected final void createTable(String... schemaSqls) throws
SQLException {
- createTableIfNotExists(connection, sqlProvider.getTableName(),
schemaSqls);
+ createTableIfNotExists(sqlProvider.getTableName(), schemaSqls);
--- End diff --
`createTableIfNotExists` was `private static` before. I needed to change it
to non-static in order for `TestJDBCDriver` to be able to access the underlying
connection to create the empty table for the test.
---
