Since I fixed it.. I will try to cut the release today.. will send it out as soon as it's ready any time now.
On Thu, Mar 8, 2018 at 7:48 PM, Clebert Suconic <clebert.suco...@gmail.com> wrote: > I think it’s importsnt to fix this bug. I broke it and I want to fix it :) > > On Thu, Mar 8, 2018 at 6:12 PM Timothy Bish <tabish...@gmail.com> wrote: >> >> On 03/08/2018 05:59 PM, Clebert Suconic wrote: >> > I'm pushing this back to monday...I thought that was an easy fix and i >> > will need some more tweaking. >> > >> > >> > Meanwhile.. @everyone: avoiding pushing anything that will break the >> > release now :) doc fixes and test fixes is of course fine. I'm running >> > the whole testsuite before each PR I send now.. which is 2 hours.. >> > anything other than that will push the release further. >> >> Why not just cut a branch now then and cherry-pick things that should go >> into 2.5.0 to make it simpler to mange ? That way work can progress on >> things that might be better in 2.6.0 concurrently >> >> > >> > On Thu, Mar 8, 2018 at 1:55 PM, Clebert Suconic >> > <clebert.suco...@gmail.com> wrote: >> >> I'm already on it... i'm working on it. >> >> >> >> On Thu, Mar 8, 2018 at 8:35 AM, Michael André Pearce >> >> <michael.andre.pea...@me.com> wrote: >> >>> Can we add >> >>> >> >>> https://github.com/apache/activemq-artemis/pull/1940 >> >>> >> >>> As a blocker. >> >>> >> >>> On reviewing the PR and seeing why this PR is needed/wanted, it seems >> >>> whilst console is most visibly affected by a change done , it has more >> >>> serious effect that the network pinger also seems to get shutdown and not >> >>> kept alive on slave failback. Concern also is if there is anything else. >> >>> >> >>> Sent from my iPhone >> >>> >> >>>> On 8 Mar 2018, at 12:28, Andy Taylor <andy.tayl...@gmail.com> wrote: >> >>>> >> >>>> I think https://issues.apache.org/jira/browse/ARTEMIS-1736 is a >> >>>> blocker as >> >>>> well, Ive just sent a PR with a fix >> >>>> >> >>>> On 7 March 2018 at 04:59, Michael André Pearce >> >>>> <michael.andre.pea...@me.com> >> >>>> wrote: >> >>>> >> >>>>> @Clebert >> >>>>> >> >>>>> Someone in the user threads has raised what looks like a blocker if >> >>>>> it’s >> >>>>> real. >> >>>>> >> >>>>> Something to do with large messages and broker crashing with >> >>>>> 2.5.0-SNAPSHOTz >> >>>>> >> >>>>> Have you seen it? >> >>>>> >> >>>>> Sent from my iPhone >> >>>>> >> >>>>>> On 2 Mar 2018, at 23:42, Clebert Suconic >> >>>>>> <clebert.suco...@gmail.com> >> >>>>> wrote: >> >>>>>> If you have anything in mind that you consider a blocking..... >> >>>>>> >> >>>>>> That’s the idea of the heads up. My expectation was the examples. >> >>>>>> But >> >>>>> if >> >>>>>> you want to request another change, like be PR pending you have >> >>>>>> that I >> >>>>> need >> >>>>>> to work on ? :) >> >>>>>> >> >>>>>> >> >>>>>> Let me know if you have anything in mind that is a blocker. >> >>>>>> >> >>>>>> On Fri, Mar 2, 2018 at 12:46 AM MichaelAndrePearce < >> >>>>>> michael.andre.pea...@me.com> wrote: >> >>>>>> >> >>>>>>> yes a list of blocking tasks, so that we can all focus on those if >> >>>>> needed. >> >>>>>>> It >> >>>>>>> sounded like there were a few examples, but it seems like you have >> >>>>>>> that >> >>>>> in >> >>>>>>> hand already. >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> -- >> >>>>>>> Sent from: >> >>>>>>> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html >> >>>>>>> >> >>>>>> -- >> >>>>>> Clebert Suconic >> >> >> >> >> >> -- >> >> Clebert Suconic >> > >> > >> >> -- >> Tim Bish >> twitter: @tabish121 >> blog: http://timbish.blogspot.com/ >> > -- > Clebert Suconic -- Clebert Suconic
