[GitHub] activemq-artemis pull request #1952: ARTEMIS-1743 fix NPE in server log when...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1952#discussion_r174094053
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
 ---
    @@ -644,8 +644,11 @@ public Message setLastValueProperty(SimpleString 
lastValueName) {
     
        @Override
        public int getEncodeSize() {
    +      if (buffer == null) {
    +         return -1;
    +      }
           checkEncode();
    --- End diff --
    
    checkEncode is using buffer therefore it is good to do null check before


---