Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1986#discussion_r179441774
  
    --- Diff: 
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
 ---
    @@ -191,9 +191,18 @@ private void createTableIfNotExists(String tableName, 
String... sqls) throws SQL
                 } else {
                    try (Statement statement = connection.createStatement();
                          ResultSet cntRs = 
statement.executeQuery(sqlProvider.getCountJournalRecordsSQL())) {
    -                  if (rs.next() && rs.getInt(1) > 0) {
    +                  int rows;
    +                  if (cntRs.next() && (rows = cntRs.getInt(1)) > 0) {
                          logger.tracef("Table %s did exist but is not empty. 
Skipping initialization.", tableName);
    +                     if (logger.isDebugEnabled()) {
    +                        final long expectedRows = 
Stream.of(sqls).map(String::toUpperCase).filter(sql -> sql.contains("INSERT 
INTO")).count();
    --- End diff --
    
    @clebertsuconic PLease do not merge it yet...because on DB2 it is creating 
some problems


---

Reply via email to