[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

Fri, 06 Apr 2018 11:48:42 -0700 

Github user ingo1121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1983
  
    Hi!
    
    Sorry for the mess with the git tree!
    
     
    
    I have some question, though: 
    
     
    
    1.  What is your normal build procedure? On my fork, I’ve made a Jenkins 
job, that just does a ”mvn install” ob the root directory; no profiles or 
anything. Is that reasonable?
    2.  I tried to make a ”full example” integration test; by running 
”mvn -Pexamples verify” on the examples directory. Unfortuatly it quickly 
runs out of steam (both on Windows and RHEL). Is this something that should be 
fixed? Should I register a JIRA? I notice that a lot of Java processes are left 
behind…
    
     
    
    Regards
    
    Ingemar
    
     
    
     
    
    FrÃ¥n: clebertsuconic <[email protected]> 
    Skickat: den 3 april 2018 00:52
    Till: apache/activemq-artemis <[email protected]>
    Kopia: ingo1121 <[email protected]>; Mention <[email protected]>
    Ämne: Re: [apache/activemq-artemis] ARTEMIS-1749 - Fixes the 
ssl-enabled-crl-mqtt (#1983)
    
     
    
    I fixed it.. but your PR was way too messed up. if I had merged your 
merges.. we would have created a mess on master. please no merge commits on PRs.
    
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub 
<https://github.com/apache/activemq-artemis/pull/1983#issuecomment-378071239> , 
or mute the thread 
<https://github.com/notifications/unsubscribe-auth/AVmUYj66_W5-JmAwnvwSRDYeaoh0m8TDks5tkqt4gaJpZM4TBFTa>
 .  
<https://github.com/notifications/beacon/AVmUYowcdPo2x9tuPC1ZkI5SiknEElKeks5tkqt4gaJpZM4TBFTa.gif>
 
    



---

Reply via email to