Github user dudaerich commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2003#discussion_r180127063
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcNodeManager.java
 ---
    @@ -95,18 +98,25 @@ public static JdbcNodeManager 
with(DatabaseStorageConfiguration configuration,
           }
        }
     
    -   static JdbcNodeManager usingDataSource(String brokerId,
    -                                          long lockExpirationMillis,
    -                                          long lockRenewPeriodMillis,
    -                                          long 
lockAcquisitionTimeoutMillis,
    -                                          long maxAllowedMillisFromDbTime,
    -                                          DataSource dataSource,
    -                                          SQLProvider provider,
    -                                          ScheduledExecutorService 
scheduledExecutorService,
    -                                          ExecutorFactory executorFactory,
    -                                          IOCriticalErrorListener 
ioCriticalErrorListener) {
    +   private static JdbcNodeManager usingDataSource(String brokerId,
    +                                                  long networkTimeout,
    +                                                  long 
lockExpirationMillis,
    +                                                  long 
lockRenewPeriodMillis,
    +                                                  long 
lockAcquisitionTimeoutMillis,
    +                                                  long 
maxAllowedMillisFromDbTime,
    +                                                  DataSource dataSource,
    +                                                  SQLProvider provider,
    +                                                  ScheduledExecutorService 
scheduledExecutorService,
    +                                                  ExecutorFactory 
executorFactory,
    +                                                  IOCriticalErrorListener 
ioCriticalErrorListener) {
           return new JdbcNodeManager(
    -         () -> JdbcSharedStateManager.usingDataSource(brokerId, 
lockExpirationMillis, maxAllowedMillisFromDbTime, dataSource, provider),
    +         () -> JdbcSharedStateManager.usingDataSource(brokerId,
    +                                                      (int) networkTimeout,
    --- End diff --
    
    Why don't you pass here long but you retype it to int?


---

Reply via email to