Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180281260
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
---
@@ -105,12 +105,16 @@ public void setUniqueEventID(final long
uniqueEventID) {
return connector;
}
+ /**
+ * We only need to check if the connection point to the same node,
+ * don't need to compare the whole params map.
+ * @param connection The connection to the target node
+ * @return true if the connection point to the same node
+ * as this member represents.
+ */
@Override
public boolean isMember(RemotingConnection connection) {
- TransportConfiguration connectorConfig =
connection.getTransportConnection() != null ?
connection.getTransportConnection().getConnectorConfig() : null;
-
- return isMember(connectorConfig);
-
+ return connection.isSameTarget(getConnector().getA(),
getConnector().getB());
--- End diff --
I ran the testsuite and itâs a lot stable now.
So let me do some tests tomorrow. I think itâs a minor change now.
Leave it with me.
---
