Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2007#discussion_r180448672
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
    @@ -39,7 +39,15 @@
        PROPOSAL(18),
        PROPOSAL_RESPONSE(19),
        UNPROPOSAL(20),
    -   CONSUMER_SLOW(21);
    +   CONSUMER_SLOW(21),
    +   ADDRESS_ADDED(22),
    +   ADDRESS_REMOVED(23),
    +   CONNECTION_CREATED(24),
    +   CONNECTION_DESTROYED(25),
    +   SESSION_CREATED(26),
    +   SESSION_CLOSED(27),
    +   MESSAGE_DELIVERED(28),
    --- End diff --
    
    isn't that too costly to the broker?
    
    that's a lot of notifications here. I don't think we should do on 
MESSAGE_DELIVERED.


---

Reply via email to