Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2010#discussion_r180858361
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
 ---
    @@ -380,7 +380,7 @@ public Packet sendBlocking(final Packet packet,
     
                 connection.getTransportConnection().write(buffer, false, 
false);
     
    -            long toWait = connection.getBlockingCallTimeout();
    --- End diff --
    
    Looking at the code, I can't see how connection will ever be null here..  I 
think you should remove this one...
    
    For instance... the very same connection was used before within a lock.. 
what would issue a NPE a lot earlier than here.
    
    I don't see how connection could ever be null.


---

Reply via email to