Great, Clebert! That's very useful: I have found sometimes my closed PRs unable to be reopened...that's why.
Thanks!! Il giorno mar 17 apr 2018 alle ore 16:13 Clebert Suconic < [email protected]> ha scritto: > If you close your pull request, you may reopen it if you keep the same > git hash before you reopen it. > > > So, on a real example, I opened > https://github.com/apache/activemq-artemis/pull/2024 > > > Now I closed it as there's a minor test I need to fix... The current > hash while closed is: 415fb3ead284464824b0bbe51a6fc1cebdb27950 > > > So, if I reopen it.. i have to reopen it still at > 415fb3ead284464824b0bbe51a6fc1cebdb27950 > > And then push the new commit with a -f into my branch. > > > > > I never read any documentations about it.. but I can only assume it's > how github will handle opening new PRs on top of your existing branch. > > > > -- > Clebert Suconic >
