Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2035#discussion_r183194622
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
---
@@ -1943,11 +1958,43 @@ public String listAllConsumersAsJSON() throws
Exception {
}
private JsonObject toJSONObject(ServerConsumer consumer) throws
Exception {
- JsonObjectBuilder obj =
JsonLoader.createObjectBuilder().add("consumerID",
consumer.getID()).add("connectionID",
consumer.getConnectionID().toString()).add("sessionID",
consumer.getSessionID()).add("queueName",
consumer.getQueue().getName().toString()).add("browseOnly",
consumer.isBrowseOnly()).add("creationTime",
consumer.getCreationTime()).add("deliveringCount",
consumer.getDeliveringMessages().size());
+ JsonObjectBuilder obj =
JsonLoader.createObjectBuilder().add("consumerID", consumer.getID())
+ .add("connectionID", consumer.getConnectionID().toString())
+ .add("sessionID", consumer.getSessionID())
+ .add("queueName", consumer.getQueue().getName().toString())
+ .add("browseOnly", consumer.isBrowseOnly())
+ .add("creationTime", consumer.getCreationTime())
+ .add("deliveringCount", consumer.getDeliveringMessages().size());
if (consumer.getFilter() != null) {
obj.add("filter",
consumer.getFilter().getFilterString().toString());
}
+ String coreAddress = consumer.getQueue().getAddress().toString();
+
+ String[] result = new String[2]; // destination name & type
--- End diff --
Please remove this is brittle code based on jms prefixes which is bad,
broker uses core model. Saying that this is address and queue level information
(e.g. Multicast vs Anycast), not consumer
---
