Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2152#discussion_r196818582
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpNoHearbeatsTest.java
 ---
    @@ -137,18 +139,21 @@ public void inspectOpenedResource(Connection 
connection) {
        }
     
        public static void main(String[] arg) {
    -      if (arg.length > 0 && arg[0].equals("testConnectionReset")) {
    +      if (arg.length > 0 && 
arg[0].startsWith("testCloseConsumerOnConnectionReset")) {
    --- End diff --
    
    How about using the argument as the queue name? That way you dont need a 
constant, and there are side benefits such as test isolation and if things to 
wonky you can read the logs and immediately know what test the output came from 
etc?


---

Reply via email to