Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r207235658
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
---
@@ -189,16 +185,24 @@ public void kill() {
this.killed = true;
}
+ private void setHandlers() {
+
sessionChannel.setCommandConfirmationHandler(commandConfirmationHandler);
--- End diff --
So issue then will be if you dont handle via the cache, the response
handlers will keep reference to it, and would slowley leak memory
---
