Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2295#discussion_r215514830
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -2718,7 +2715,7 @@ private void
undeployAddressesAndQueueNotInConfiguration(Configuration configura
removeAddressInfo(addressName, null);
} else if (addressSettings.getConfigDeleteQueues() ==
DeletionPolicy.FORCE) {
for (Queue queue : listConfiguredQueues(addressName)) {
- if
(!queuesInConfig.contains(queue.getRoutingType().toString() +
queue.getName().toString())) {
+ if
(!queuesInConfig.contains(CoreQueueConfiguration.getCoreQueueConfiguration(queue).hashCode()))
{
--- End diff --
Hash code is not safe unique. Should keep the equals on name
---