Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2328#discussion_r220276439
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
---
@@ -1056,4 +1107,26 @@ public static void setObjectProperty(final
SimpleString key, final Object value,
throw new ActiveMQPropertyConversionException(value.getClass() +
" is not a valid property type");
}
}
+
+
+
+ private <T> T withWriteLock(Supplier<T> supplier) {
+ long lock = this.writeLock();
+ try {
+ return supplier.get();
+ } finally {
+ this.unlockWrite(lock);
+ }
+ }
+
+ private <T> T withReadLock(Supplier<T> supplier) {
--- End diff --
God damn you @franz1981 you make me look again...ok, let me do the ugly
option, but most perf, and see how ugly it becomes....
---