[GitHub] activemq-artemis pull request #2181: ARTEMIS-1980 Warn on failed check of ta...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2181#discussion_r221341953
  
    --- Diff: 
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
 ---
    @@ -227,7 +227,11 @@ private void createTableIfNotExists(String tableName, 
String... sqls) throws SQL
                       }
                    }
                 } catch (SQLException e) {
    -               logger.warn(JDBCUtils.appendSQLExceptionDetails(new 
StringBuilder("Can't verify the initialization of table 
").append(tableName).append(" due to:"), e, 
sqlProvider.getCountJournalRecordsSQL()));
    +               if (logger.isDebugEnabled()) {
    --- End diff --
    
    the if (logger.isDebugEnable()) is meant to avoid sending something to 
debug and have it ignored.
    
    
    you have two options:
    
    either:
    ```java
    if (logger.isDebugEnabled()) { 
      logger.debug(....);
    }
    ```
    
    
    or
    
    
    ```java
     logger.infof (...);
    ```
    
    
    keep it simple... mixing it like that may confuse debugging and the user In 
my experience.


---