Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2187#discussion_r222357714
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/SendAcknowledgementHandler.java
---
@@ -41,4 +41,13 @@
* @param message message sent asynchronously
*/
void sendAcknowledged(Message message);
+
+ default void sendFailed(Message message, Exception e) {
+ /**
+ * By default ignore failures to preserve compatibility with
existing implementations.
+ * If the message makes it to the broker and a failure occurs
sendAcknowledge() will
--- End diff --
I'm not going digging with tests, I just thought I'd point out the
apparently incorrect comment added, and seeming change of behaviour to what it
comments on. If you can't see an issue thats fine.
---
