Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2371#discussion_r225165274
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
---
@@ -1789,6 +1790,11 @@ public synchronized RoutingStatus doSend(final
Transaction tx,
AddressInfo art = getAddressAndRoutingType(new
AddressInfo(msg.getAddressSimpleString(), routingType));
+ if (postOffice.isAddressBlocked(msg.getAddressSimpleString())) {
--- End diff --
I think the use case here is wrong. With block you just stop sending
credits to the client.
This becomes fail at this point.
We have two options:
- If you had previously sent credits to the client.. then you must complete
the operations until you have full credits.
- or we could hung to these on the server. But that would have a risk of
running OME. So I would say we just stop sending credits.
---
