Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2401#discussion_r229110673
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -700,7 +720,7 @@ public boolean checkMemory(final Runnable
runWhenAvailable) {
@Override
public void addSize(final int size) {
- boolean globalFull = pagingManager.addSize(size).isGlobalFull();
+ boolean globalFull = !ignoreGlobalMaxSize &&
pagingManager.addSize(size).isGlobalFull();
--- End diff --
I agree: indeed it was one of my concern on it.
On one side to not impact other addresses and trigger paging due to
management messages and on the other side to maintain consistency of the
metrics related to address utilization.
Obviously just one of the paths can be chosen: I take your point and I
agree to maintain correct metrics instead :+1:
---
