Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2414#discussion_r230684013
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1244,6 +1244,9 @@ private static PageSubscription
locateSubscription(final long queueID,
if (queueInfo != null) {
SimpleString address = queueInfo.getAddress();
PagingStore store = pagingManager.getPageStore(address);
--- End diff --
@wy96f I'm not following, that method is used purely for the File journal
during replication. The null check on paging store is due to, the additional
bits in getPageStore(SimpleString storeName).
```java
if (managementAddress != null &&
storeName.startsWith(managementAddress)) {
return null;
}
```
---
