[GitHub] activemq-artemis pull request #2444: ARTEMIS-2186 Large message incomplete w...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2444#discussion_r236681572
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java
 ---
    @@ -1018,6 +1018,7 @@ private void sendContinuations(final int packetSize,
              currentLargeMessage.addBytes(body);
     
              if (!continues) {
    +            currentLargeMessage.sync();
                 currentLargeMessage.releaseResources();
    --- End diff --
    
    wouldn't releaseResources make a sync when the file is closed?


---