Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986539
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
 ---
    @@ -95,6 +109,7 @@ public void encodeRest(final ActiveMQBuffer buffer) {
           buffer.writeNullableSimpleString(filterString);
           buffer.writeBoolean(browseOnly);
           buffer.writeBoolean(requiresResponse);
    +      buffer.writeInt(priority);
    --- End diff --
    
    I will write it as a byte, if we don't plan to support more then 127 
priorities, consumer-side: but as I've said is a negligible save of space on 
the wire


---

Reply via email to