[GitHub] activemq-artemis pull request #2483: ARTEMIS-2215 largemessage have been con...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2483#discussion_r245090041
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
 ---
    @@ -309,16 +309,17 @@ public void run() {
         */
        @Override
        protected void performCachedLargeMessageDeletes() {
    -      for (Long largeMsgId : largeMessagesToDelete) {
    -         SequentialFile msg = createFileForLargeMessage(largeMsgId, 
LargeMessageExtension.DURABLE);
    +      for (LargeServerMessage largeServerMessage : 
largeMessagesToDelete.values()) {
    --- End diff --
    
    Usage of LongConcurrentHashMap  looks much better.


---