Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2482#discussion_r245233815
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
 ---
    @@ -120,14 +126,16 @@ public PagedReferenceImpl(final PagePosition position,
              this.largeMessage = message.getMessage().isLargeMessage() ? 
IS_LARGE_MESSAGE : IS_NOT_LARGE_MESSAGE;
              this.transactionID = message.getTransactionID();
              this.messageID = message.getMessage().getMessageID();
    -
    +         this.durable = message.getMessage().isDurable() ? IS_DURABLE : 
IS_NOT_DURABLE;
    +         this.deliveryTime = 
message.getMessage().getScheduledDeliveryTime();
              //pre-cache the message size so we don't have to reload the 
message later if it is GC'd
              getPersistentSize();
           } else {
              this.largeMessage = UNDEFINED_IS_LARGE_MESSAGE;
              this.transactionID = -2;
              this.messageID = -1;
              this.messageSize = -1;
    +         this.durable = UNDEFINED_IS_DURABLE;
    --- End diff --
    
    for completeness (its a nit) set deliveryTime to its undefined value here.


---

Reply via email to