franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454285382 @CNNJYB in this case it is wanted: compaction was leaking buffers big as as the file size, while with paging not. The point is that a thread local pool buffer is not a perfect solution, but is better then no pooling (using heap buffers and FileChannel means that FileChannel will leak a direct ByteBuffer and will perform an hidden copy) or a shared (among threads) pool. We can rethink pooling according to the lifecycle of who perform the page write: any proposal is welcome to solve it :+1
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
