franz1981 commented on a change in pull request #2427: ARTEMIS-2170 Optimized
CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248889763
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
##########
@@ -318,6 +313,30 @@ public synchronized boolean containsProperty(final
SimpleString key) {
}
}
+ public synchronized boolean removeProperty(Predicate<SimpleString>
propertyNamePredicate) {
Review comment:
Yep, then original version was using a slower method to remove a property
matching specific criteria and it was used in the hot path for every message.
This change has improved (for small binary message) the throughput of core
on my tests by a perceivable quantity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
