michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456126234 /Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/bin/java "-javaagent:/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=55444:/Applications/IntelliJ IDEA.app/Contents/bin" -Dfile.encoding=UTF-8 -classpath /Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/deploy.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/cldrdata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/dnsns.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/jaccess.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/jfxrt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/localedata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/nashorn.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/sunec.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/sunjce_provider.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/sunpkcs11.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/ext/zipfs.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/javaws.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/jce.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/jfr.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/jfxswt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/jsse.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/management-agent.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/plugin.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/resources.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre/lib/rt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/lib/ant-javafx.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/lib/dt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/lib/javafx-mx.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/lib/jconsole.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/lib/packager.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/lib/sa-jdi.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/lib/tools.jar:/Users/pearcem/Documents/dev/activemq-artemis-may/artemis-core-client/target/classes:/Users/pearcem/.m2/repository/org/jgroups/jgroups/3.6.13.Final/jgroups-3.6.13.Final.jar:/Users/pearcem/Documents/dev/activemq-artemis-may/artemis-commons/target/classes:/Users/pearcem/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar:/Users/pearcem/.m2/repository/commons-logging/commons-logging/1.2/commons-logging-1.2.jar:/Users/pearcem/.m2/repository/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar:/Users/pearcem/.m2/repository/org/apache/geronimo/specs/geronimo-json_1.0_spec/1.0-alpha-1/geronimo-json_1.0_spec-1.0-alpha-1.jar:/Users/pearcem/.m2/repository/org/apache/johnzon/johnzon-core/0.9.5/johnzon-core-0.9.5.jar:/Users/pearcem/.m2/repository/io/netty/netty-transport-native-epoll/4.1.28.Final/netty-transport-native-epoll-4.1.28.Final-linux-x86_64.jar:/Users/pearcem/.m2/repository/io/netty/netty-transport-native-unix-common/4.1.28.Final/netty-transport-native-unix-common-4.1.28.Final.jar:/Users/pearcem/.m2/repository/io/netty/netty-transport-native-kqueue/4.1.28.Final/netty-transport-native-kqueue-4.1.28.Final-osx-x86_64.jar:/Users/pearcem/.m2/repository/io/netty/netty-codec-http/4.1.28.Final/netty-codec-http-4.1.28.Final.jar:/Users/pearcem/.m2/repository/io/netty/netty-buffer/4.1.28.Final/netty-buffer-4.1.28.Final.jar:/Users/pearcem/.m2/repository/io/netty/netty-transport/4.1.28.Final/netty-transport-4.1.28.Final.jar:/Users/pearcem/.m2/repository/io/netty/netty-resolver/4.1.28.Final/netty-resolver-4.1.28.Final.jar:/Users/pearcem/.m2/repository/io/netty/netty-handler/4.1.28.Final/netty-handler-4.1.28.Final.jar:/Users/pearcem/.m2/repository/io/netty/netty-codec/4.1.28.Final/netty-codec-4.1.28.Final.jar:/Users/pearcem/.m2/repository/io/netty/netty-common/4.1.28.Final/netty-common-4.1.28.Final.jar org.apache.activemq.artemis.core.message.impl.Hello test one check empty we dont iterate test two, check on not using an internal property we dont iterate test three, on setting an internal property, even if not one we want to remove, we iterate i should be called
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
