michaelandrepearce commented on a change in pull request #2510: [ARTEMIS-2156]
Message Duplication when using exclusive divert and clustering
URL: https://github.com/apache/activemq-artemis/pull/2510#discussion_r249528463
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
##########
@@ -117,7 +117,9 @@ public void addBinding(final Binding binding) {
logger.trace("addBinding(" + binding + ") being called");
}
if (binding.isExclusive()) {
- exclusiveBindings.add(binding);
+ if (!exclusiveBindings.contains(binding)) {
Review comment:
The change is just to the collection exclusive bindings. You are making set
semantics on that.
Im against doing a contains and then adds non atomically (or non concurrent
safe)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
