ldebello commented on a change in pull request #2510: [ARTEMIS-2156] Message
Duplication when using exclusive divert and clustering
URL: https://github.com/apache/activemq-artemis/pull/2510#discussion_r249535874
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
##########
@@ -117,7 +117,9 @@ public void addBinding(final Binding binding) {
logger.trace("addBinding(" + binding + ") being called");
}
if (binding.isExclusive()) {
- exclusiveBindings.add(binding);
+ if (!exclusiveBindings.contains(binding)) {
Review comment:
@michaelandrepearce @jbertram change the structure from list to set in
exclusive binding should be easy but my point is also bindings have set
semantics
https://github.com/apache/activemq-artemis/blob/65d01a4f9195737708ec82ee216afe3f196b27bc/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java#L136
so change only one side is a little weird for me and changing everything
sounds like doing something different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
