franz1981 edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456176258 > output: > > test one check empty we dont iterate > test two, check on not using an internal property we dont iterate > test three, on setting an internal property, even if not one we want to remove, we iterate > i should be called > > which shows the optimisation that we ONLY iterate if an internal property was set, is there in master. This is not what I have verified in the past: let me try another time, but just putting a log on the iteration on a single producer/single consumer test will show it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
