michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251182839
########## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java ########## @@ -397,6 +380,55 @@ public MessageProducer createProducer(final Destination destination) throws JMSE } } + void checkDestination(ActiveMQDestination destination) throws JMSException { Review comment: +1 same here not the biggest fan of them either, i remember having on another project starting with the name K ;), such issue, and getting people to agree to make it non final was a nightmare. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services