michaelandrepearce commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251184000
########## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFile.java ########## @@ -301,21 +269,19 @@ protected ByteBuffer newBuffer(int size, int limit) { protected class LocalBufferObserver implements TimedBufferObserver { Review comment: Is it worth extracting this to its own class file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services