franz1981 commented on a change in pull request #2522: ARTEMIS-2239 Zero-copy
NIO/MAPPED TimedBuffer
URL: https://github.com/apache/activemq-artemis/pull/2522#discussion_r251192884
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/nio/NIOSequentialFile.java
##########
@@ -51,6 +55,34 @@ public NIOSequentialFile(final SequentialFileFactory
factory,
this.maxIO = maxIO;
}
+ @Override
+ protected TimedBufferObserver createTimedBufferObserver() {
+ return new LocalBufferObserver() {
Review comment:
I can do it, but (for this specific class) I can't see the benefits.
In a future implementation I would like to abstract away things like
`AbstractSequentialFile::fileSize` and create 2 separate classes:
`AsyncLocalBufferObserver` and `SyncLocalBufferObserver`.
The former that perform the copy because it assymes asynchrounous writes,
the latter not.
But at this point, given that the classes are packed into their owner seq
file class probably I could just let them be where/as they are to reduce the
code changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
