jbertram commented on a change in pull request #2541: ARTEMIS-2246 clarify
max-disk-usage 'default'
URL: https://github.com/apache/activemq-artemis/pull/2541#discussion_r254503529
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -749,10 +749,10 @@
</xsd:annotation>
</xsd:element>
- <xsd:element name="max-disk-usage" type="xsd:int" default="90"
maxOccurs="1" minOccurs="0">
+ <xsd:element name="max-disk-usage" type="xsd:int" default="100"
maxOccurs="1" minOccurs="0">
Review comment:
I think you guys should read the
[JIRA](https://issues.apache.org/jira/browse/ARTEMIS-2246). Changing the XSD
does *not* change the actual default in the code. The default in the code is
_already_ `100`. This is also noted in the documentation. The XSD change is
just to avoid confusion between the schema and the docs. Lastly, the
out-of-the-box broker.xml sets `max-disk-usage` to `90`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
