michaelandrepearce commented on a change in pull request #2541: ARTEMIS-2246
clarify max-disk-usage 'default'
URL: https://github.com/apache/activemq-artemis/pull/2541#discussion_r254569161
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -749,10 +749,10 @@
</xsd:annotation>
</xsd:element>
- <xsd:element name="max-disk-usage" type="xsd:int" default="90"
maxOccurs="1" minOccurs="0">
+ <xsd:element name="max-disk-usage" type="xsd:int" default="100"
maxOccurs="1" minOccurs="0">
Review comment:
Maybe be better to change doc and code default to that in the schema? Having
a max at 100 once disk is full its normally to late. I think its better we have
safe defaults
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
